Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The endpoint is opening files without init and can't be shutdown #360

Open
1 of 5 tasks
ate47 opened this issue May 17, 2023 · 0 comments
Open
1 of 5 tasks

The endpoint is opening files without init and can't be shutdown #360

ate47 opened this issue May 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ate47
Copy link
Collaborator

ate47 commented May 17, 2023

Part of the endpoint? (leave empty if you don't know)

  • Backend (qendpoint-backend)
  • Store (qendpoint-backend)
  • Core (qendpoint-core)
  • Frontend (qendpoint-frontend)
  • Other

Description of the issue

When the endpoint is created using the constructor EndpointStore(Path), the native stores are created, but usually they're closed using the EndpointStore#shutDown() method, but this method isn't doing anything if the Sail isn't init with EndpointStore#init(), leading to the files still being open.

Excepted behavior

Shutdown the native stores

Obtained behavior

no shutdown of the native stores

How to reproduce

Path location = Path.of("qendpoint");
EndpointStore endpointStore = new EndpointStore(location);
// add this line to see the bug
// endpointStore.init(); 
endpointStore.shutDown();
PathUtils.deleteDirectory(location);

Endpoint version

1.12.0

Do I want to contribute to fix it?

Maybe

Something else?

No response

@ate47 ate47 added the bug Something isn't working label May 17, 2023
ate47 added a commit that referenced this issue May 17, 2023
* GH-336 add/search multiple HDT and consider #360 in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant