Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignUp page doesn't redirect #6

Closed
spencexyz opened this issue Apr 23, 2018 · 5 comments
Closed

SignUp page doesn't redirect #6

spencexyz opened this issue Apr 23, 2018 · 5 comments

Comments

@spencexyz
Copy link

event.preventDefault() doesn't appear to be working on the SignUp page, which causes the page to refresh and the user is never redirected.

@rwieruch
Copy link
Member

Hm, I never experienced this nor did anybody else. Why do you think that it doesn't work?

@spencexyz
Copy link
Author

Hey, thanks for getting back to me. I just realized I changed something in the doCreateUser in db.js.

When I change it to this:

export const doCreateUser = (id, fullname, username, email) => {
  db.ref(`users/${username}`).set({
    fullname,
    email,
  });
}

it doesn't work anymore. Do you know why this might be?

@spencexyz
Copy link
Author

It looks like my addition of {}broke it by not returning the promise. Then I get Can't call setState (or forceUpdate) on an unmounted component. in the console, which went away when I removed // this.setState(() => ({ ...INITIAL_STATE }));. Thanks for the quick response, sorry about opening a bug for something that was user error.

@rwieruch
Copy link
Member

No worries. Glad that you've figured out the issue :)

@spyro254
Copy link

Just to clarify, in case anyone comes into contact with this issue. The AUTH API within the firebase.js file uses fat arrow functions without curly braces. If curly braces are introduced, a return statement is required in order for the promise to be returned for the .then function in the SignUp component.

.then is undefined in the following:
doCreateUserWithEmailAndPassword = (email, password) => { this.auth.createUserWithEmailAndPassword(email, password); }

the following options return a valid response:

(return statement added)
doCreateUserWithEmailAndPassword = (email, password) => { return this.auth.createUserWithEmailAndPassword(email, password); }

or (no curly braces)
doCreateUserWithEmailAndPassword = (email, password) => this.auth.createUserWithEmailAndPassword(email, password);

Correct me if I'm wrong! (Amazing work, by the way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants