struct pcap bug on NetBSD 4.0_BETA2 (and possibly earlier)

[guyharris]

Converted from SourceForge issue 1675999, submitted by hans_rosenfeld

This one is really nasty.

In pcap-int.h, struct pcap is declared to contains a member "fddipad" if PCAP_FDDIPAD is defined, which is defined for NetBSD iff NetBSD_Version is above 106000000, NetBSD_Version is defined in <sys/param.h>.

It happens that pcap-bpf.c includes <sys/param.h>, so when pcap-int.h is included struct pcap is declared and used with the member fddipad. But in pcap.c, <sys/param.h> is not included, neither directly nor indirectly, so when pcap-int.h is included struct pcap is declared and used without the member fddipad.

Now pcap-bpf.c initializes a struct pcap with some function pointers, which just happen to be defined after fddipad. So when pcap.c tries to call such a function, it gets the wrong one. And then it breaks.

Solution:

include <sys/param.h> in pcap.c or pcap-int.h, maybe #ifdef'ed NetBSD

[guyharris]

Submitted by guy_harris

Logged In: YES
user_id=541179
Originator: NO

I've checked into the main and x.9 branches a change that includes <sys/param.h> in pcap-int.h if NetBSD is defined. See if that works.

[guyharris]

Submitted by guy_harris

Logged In: YES
user_id=541179
Originator: NO

I've checked into the main and x.9 branches a change that includes <sys/param.h> in pcap-int.h if NetBSD is defined. See if that works.