Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpdump manpage has incomplete docs on TCP headers #31

Closed
guyharris opened this issue Apr 16, 2013 · 1 comment
Closed

tcpdump manpage has incomplete docs on TCP headers #31

guyharris opened this issue Apr 16, 2013 · 1 comment

Comments

@guyharris
Copy link
Member

Converted from SourceForge issue 753399, submitted by arach

I got this reported to us and I think it belongs upstream.

reporter:rindolf@snappydsl.net
http://bugs.gentoo.org/show_bug.cgi?id=21312
Regards,
Spider@gentoo.org


There are two TCP headers, ECN Echo and ECN Cwnd
Reduced, that tcpdump
recognizes and outputs the existence of, but aren't
listed in the manpage. The
relevant section of tcpdump.1, near the top of the TCP
Packets section, line 743:

   Flags  are some combination of S (SYN), F (FIN),

P (PUSH) or R (RST) or
a single `.' (no flags). Data-seqno describes
the portion of sequence

The part of print-tcp.c that produces the header flag
output, inside the
function tcp_print, line 274:

if ((flags = tp->th_flags) &
(TH_SYN|TH_FIN|TH_RST|TH_PUSH|
TH_ECNECHO|TH_CWR)) {
if (flags & TH_SYN)
putchar('S');
if (flags & TH_FIN)
putchar('F');
if (flags & TH_RST)
putchar('R');
if (flags & TH_PUSH)
putchar('P');
if (flags & TH_CWR)
putchar('W');/* congestion _W_indow reduced (ECN) /
if (flags & TH_ECNECHO)
putchar('E');/
ecn _E_cho sent (ECN) */
} else
putchar('.');

W and E are not documented in the manpage.

Reproducible: Always
Steps to Reproduce:
1.Run tcpdump
2.Receive a packet with the W or E header flags set
3.Wonder what W and E mean, as they aren't in the manpage.

@guyharris
Copy link
Member Author

Submitted by guy_harris

Logged In: YES
user_id=541179

An update to the man page has been checked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant