Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how to improve ways of working so that PRs and issues don't get super long #128

Closed
KirstieJane opened this issue Jan 15, 2019 · 2 comments · Fixed by #176
Closed

Comments

@KirstieJane
Copy link
Collaborator

Detailed description

  • The problem with writing collaboratively and openly with lots of feedback is that some of the threads get SUPER long! See @r-j-arnold's PR for the version control chapter [Ready for review] Version control chapter #88 🙀
  • There are probably some human ways of splitting up these conversations into more manageable chunks....this issue is to capture thoughts around developing that process 👾
@KirstieJane KirstieJane added this to New issues in The Turing Way Kanban Board via automation Jan 15, 2019
@KirstieJane KirstieJane self-assigned this Jan 15, 2019
@r-j-arnold
Copy link
Collaborator

Suggested idea

Chapter developed on a person's fork. When ready for review make a branch on the turing way repo for the chapter. Make a pull request from the chapter developer's fork to that branch.

High level reviews go on that pull request, major changes to structure etc. Changes requested should be of the scale of paragraphs+, not sentences.

Following that merge to the chapter branch on the turing repo.

Subsequent changes made via pull requests to that branch, and discussed in issues linked to and summarised in the main chapter issue.

When everyone's happy merge to Turing master.

@r-j-arnold
Copy link
Collaborator

Changes added to contributing guidelines

The Turing Way Kanban Board automation moved this from New issues to Done Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants