Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topo scale feature for large mega macro topos to make features smaller #1701

Open
4 tasks
brendanheywood opened this issue Oct 26, 2014 · 7 comments
Open
4 tasks
Assignees
Labels
5: Enhancement Build up on existing function that adds or improve functionality significantly Area: Multipitch Feature: Phototopo Outsource

Comments

@brendanheywood
Copy link
Member

From Julian S:

The belay/anchor points in the current topos are what I was talking about. Obviously you need to indicate the pitch ending, but the current 'dot' is huge. On a distant photo topo Perry's the dots and lines conceal quite a lot of 'wall space'. As such, you lose perspective and, moreover, any appeal the wall might have. For instance, there are now quite a few pitches to the right of Red Edge (Perry's Lookdown) at pitches 3, 4 and 5. (http://www.thecrag.com/climbing/australia/blue-mountains/perrys-lookdown/route/13161403). If I put them in it pretty much covers the entire wall; literally blanks it out.

The lines need to be about the width of the black edging of the current lines, or thinner, on both the distant and the zoomed in version.

  • need to add topo field for storing a scale factor, most topos will be 1 but larger topos could be .8 or .5. This scale factor applies to all drawn features, effectively exactly the same as if the topo was made 2 times bigger and then responsively scaled down
  • add atomTopo template data for scale
  • add extra field to api endpoint for saving it
  • wire in to topo JS (already working)
@brendanheywood brendanheywood added 5: Enhancement Build up on existing function that adds or improve functionality significantly Feature: Phototopo labels Oct 26, 2014
@brendanheywood brendanheywood self-assigned this Oct 26, 2014
@brendanheywood
Copy link
Member Author

@brendanheywood brendanheywood modified the milestone: Release 57? - Topo polish Aug 19, 2016
@brendanheywood brendanheywood changed the title Add topo scale feature for large macro topos to make features smaller Add topo scale feature for large mega macro topos to make features smaller Nov 5, 2017
@brendanheywood
Copy link
Member Author

@killakalle
Copy link

@scd @rouletout
After enabling high-quality photos in one of the recent releases, wouldn't it be a logical next step to think about the scaling of the topo features and icons? Just thinking out loud.

@scd
Copy link
Member

scd commented Dec 4, 2020

Yup. What you don't know is that we have somebody new taking over maintenance of topo code and he is building a new version of the topo.

The photo res is something I did with the old code because it was fairly easy, but the other scaling issues is way more difficult so I did not take it on considering we have a new version coming out sometime.

We are now really stuck for topo improvements until the new version comes out.

@killakalle
Copy link

An interesting observation:

Apparently different scaling of topo features is used depending on whether the same topo is displayed on an area vs on a route detail page.

See these examples:
https://www.thecrag.com/es/escalar/spain/alto-mijares/casucho/area/587201946
https://www.thecrag.com/es/escalar/spain/alto-mijares/casucho/route/870992673

On the area the topo features are too big and it's messy:
image

On the route detail the topo features have a nice scale
image

When editing the topo (from the route detail view), it shows again the bigger (messy) features
image

@scd
Might it be worth exploring to use the same method for topos from the route detail view on the area view (and also when drawing topos)

@killakalle
Copy link

I'm now using the following workaround:

I try to make topo photos as "flat" as possible by cutting away landscape above and below the routes. This results in a wider display of the topo images. As a side-effect the topo lines are also drawn finer on wider topo images.

image

Also related to #3415

@killakalle
Copy link

There is actually an interesting effect when you look at the same topo on the crag level vs on the route level.

On the crag level features are drawn bigger. This often results in the number boxes overlaying each other. If you look at the same topo image on a route level, features are drawn smaller and you can most times read the individual number fields.

image

I'm not a developer, but could it be already helpful to just apply the same settings as used on the route detail page also on the crag overview page?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5: Enhancement Build up on existing function that adds or improve functionality significantly Area: Multipitch Feature: Phototopo Outsource
Projects
None yet
Development

No branches or pull requests

3 participants