Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PDF topos lines and labels from raster back to svg lines on photos #2706

Closed
dragonfirexx opened this issue Apr 14, 2017 · 5 comments
Closed
Labels
2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: PDF Feature: Phototopo

Comments

@dragonfirexx
Copy link

I've just tried downloading the instant pdf for Skaha and noticed that for larger wide shot images, the numbering on the topos are very blurry to the point of incomprehensible. I try zooming in on the pdf and it just gets blurrier. The vertical shots are usually fuzzy but better to see.
(This happens the same when I try to custom download pdf in single column as well)

Skaha PDF: https://static.thecrag.com/pdf/11758591.pdf

Side by side:
image

What you expected:
I was expecting to be able to see the numbers so i can figure out which route is which.

@brendanheywood brendanheywood added 2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: PDF Feature: Phototopo labels Apr 22, 2017
@brendanheywood
Copy link
Member

Root cause is we shouldn't be serving a raster for the topo, it should be an svg which references the base raster. The lines should be bezier curves not pixels.

Give this comment: #1881 (comment), ie that we are already using svg within the existing pdf pipeline this seems quite promising that this will be viable.

@scd
Copy link
Member

scd commented Aug 14, 2017

It use to work this way but had to abandon it for some reason. We extracted svg from the rendered topo page using phantom. I cannot remember the exact difficulty, but there was some problem. Just be warned that there there might be some debugging required to get this working again.

@brendanheywood brendanheywood added this to the Release 62 - xxx milestone May 22, 2018
@brendanheywood brendanheywood changed the title Instant PDF topo numbering blurry on large images Convert PDF topos lines and labels from raster back to svg lines on photos May 22, 2018
@brendanheywood
Copy link
Member

This one is most fixed now as the res of the topos has been bumped up, but I'll keep it open and use this as a placeholder for converting the lines and labels back to svg

@brendanheywood
Copy link
Member

+1 via #3326

For example in this area https://www.thecrag.com/climbing/mexico/el-salto/area/1667175816 the image of the topo has unreadable labels (see screenshot).

Ideally also provide screenshots:

img_3808

Readable numbers on topo

@scd
Copy link
Member

scd commented Jan 11, 2021

I think I made some fixes to this a while ago.

@scd scd closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Bug fix Feature that does not work as intended, broken UI, problem that detract from normal user experience Area: PDF Feature: Phototopo
Projects
None yet
Development

No branches or pull requests

3 participants