originalFocusedElement cannot be garbage collected when returnFocus is false

[mariuslukose]

Description

• onActivation handler in Lock.js file sets originalFocusedElement ref to document.activeElement (if it exists):

  react-focus-lock/src/Lock.js

  Line 46 in 6117039

  originalFocusedElement.current = (

• But it does not get reset in returnFocus handler if returnFocus prop isn't true (nor, apparently, anywhere else..):

  react-focus-lock/src/Lock.js

  Line 64 in 6117039

  if (Boolean(shouldReturnFocus) && current && current.focus) {

Issue
If originalFocusedElement is removed from DOM, but Lock component is not, then that originalFocusedElement cannot be garbage collected causing a memory leak.

Maybe originalFocusedElement ref could be reset in returnFocus handler, even when returnFocus prop is false?

[theKashey]

Good catch. Let me refactor the code a little bit to make onDeactivation act as a proper destructor.