Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Hashmap resizing. #32

Open
marrblue opened this issue May 17, 2024 · 0 comments
Open

Question about Hashmap resizing. #32

marrblue opened this issue May 17, 2024 · 0 comments

Comments

@marrblue
Copy link

Hi Dr. Dong @theNded
Thanks for your amazing work and great project!

Here I have a question and looking forward your help : )
I noticed that HashEmbedding class disabled resizing to maintain a static embedding.
Is it because the indices of the hashmap will change after resizing.
If it is feasible to achieve dynamic embedding allocation during incremental mapping based on it.
For example we explicitly allocate a embedding index to each grids like {grid_coor, embedding_idx}.
When the capacity is less than we need, we extend the embeddings and resize the hashmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant