Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QIP - Better format of wallet addresses #44

Merged
merged 4 commits into from Jul 28, 2023
Merged

Conversation

Robyer
Copy link
Contributor

@Robyer Robyer commented Jul 27, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for jolly-meninsky-145e4d ready!

Name Link
🔨 Latest commit d2d822f
🔍 Latest deploy log https://app.netlify.com/sites/jolly-meninsky-145e4d/deploys/64c3df577ecd630008953568
😎 Deploy Preview https://deploy-preview-44--jolly-meninsky-145e4d.netlify.app/qips/qip018
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CrypTrip
Copy link

I'll support this, ease of recognition will help speed up visual address audits and reduce losses from mishap.

@surg0r
Copy link
Member

surg0r commented Jul 28, 2023

I would certainly support a shorter less unwieldly address format.

I think it would be worth hearing @cyyber thoughts on this too.

@cyyber
Copy link
Member

cyyber commented Jul 28, 2023

I am in complete favor of this QIP. The address is still human readable but shorter, most likely to result into less human errors compared to existing address length.

In terms of changes, it will also require changes into the solidity complier for the Zond to support this format, as the address data type in the existing Solidity compiler takes input in the format 0x or Q followed by hexadecimal string. The address data type in the compiler needs to be changed to support this QIP.

@successor1
Copy link
Contributor

successor1 commented Jul 28, 2023

I do support this QIP. Reasons have already been stated above.

@bsnoot0
Copy link

bsnoot0 commented Jul 28, 2023

I support this QIP

@jackalyst jackalyst merged commit 970326b into theQRL:master Jul 28, 2023
5 checks passed
@OTDtoGitHub
Copy link

Feels right and most of the experts aknowledge is a better format.
Also the update window at the same time with the ZOND (testnet) release can provide a good opportunity to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants