New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 bringup #3
V2 bringup #3
Conversation
Amazing! I will implement the search mods api soon (I'm busy with Ferium and related projects rn). Also it seems that only listing project's versions has query filters? |
The idea was to unify how you add filters/parameters for searching + version list + the others that require auth (should those eventually ne added) under a common type, though on a second thought it will lead to a false sense of "oh this is a valid parameter for this query". |
Did an attempt on adding filtering to
|
Very cool! Although using string manipulation at this point would be quite dangerous. I think we should use |
Hey! I've added this PR to the |
This is still a WIP, but I might as well open it already. V1 to V2 migration guide can be found here
mod
>project
).To consider:
permissions
inTeamMember
is defined here#[serde(deny_unknown_fields)]
to catch inconsistencies earlier may be usefulBytes
to avoid having to explicitly add it to the dependency list if not used anywhere else.I'd want to see support added for using filters in the queries. Maybe something like the following could work to still keep the text based ones simple:
And then some logic inside each function (
get_mod
,list_mods
, etc) to handle the filters that are valid for the endpoint being reached.