Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Unable to open all links (API 30+ restriction) #9615

Closed
5 of 6 tasks
Jean-BaptisteC opened this issue Jan 1, 2023 · 2 comments
Closed
5 of 6 tasks

[Nightly] Unable to open all links (API 30+ restriction) #9615

Jean-BaptisteC opened this issue Jan 1, 2023 · 2 comments
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software

Comments

@Jean-BaptisteC
Copy link

Jean-BaptisteC commented Jan 1, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

nightly-24

Steps to reproduce the bug

  1. Open app
  2. Select video
  3. Use open in browser button

Expected behavior

Video link is open in browser

Actual behavior

Android show toast No app on your device can open this and browser is not started with url video

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 13

Affected device model

Pixel 6

Additional information

This bug was detected in this nightly build not on latest release.

This bug impact all links in app openable by browser

I confirm this bug is not present on 24.1 release.
I used Google Chrome like browser in my device.

This bug is maybe caused by this PR #9306

@Jean-BaptisteC Jean-BaptisteC added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jan 1, 2023
@Jean-BaptisteC Jean-BaptisteC changed the title Unable to open all links on nightly builds Unable to open all links on latest nightly build Jan 1, 2023
@plasticanu
Copy link
Contributor

plasticanu commented Jan 4, 2023

In newer version of Android, the app can't see other apps in the system. Needs to give a permission on the top level of the manifest. For example:

    <!-- Give package visibility -->
    <queries>
        <intent>
            <action android:name="android.intent.action.VIEW" />
            <data android:scheme="https" />
        </intent>
    </queries>

I tested the code and can open a browser.
https://medium.com/androiddevelopers/package-visibility-in-android-11-cc857f221cd9

@AudricV AudricV added device/software specific Issues that only happen on some devices or with some specific hardware/software and removed needs triage Issue is not yet ready for PR authors to take up labels Jan 4, 2023
@opusforlife2 opusforlife2 changed the title Unable to open all links on latest nightly build Unable to open all links (API 33 restriction) Jan 4, 2023
@AudricV AudricV changed the title Unable to open all links (API 33 restriction) [Nightly] Unable to open all links (API 33 restriction) Jan 16, 2023
@Stypox
Copy link
Member

Stypox commented Jan 16, 2023

@plasticanu if you want to open a PR feel free to do so, otherwise I'll do it. In case you do, make sure to include "http" and "market", which might be used in the app. Thanks!

Oh, maybe you also need to add <package android:name="org.xbmc.kore" /> for Kodi, because of this, but I'm not sure.

@Stypox Stypox changed the title [Nightly] Unable to open all links (API 33 restriction) [Nightly] Unable to open all links (API 31+ restriction) Jan 29, 2023
@Stypox Stypox changed the title [Nightly] Unable to open all links (API 31+ restriction) [Nightly] Unable to open all links (API 30+ restriction) Jan 29, 2023
@AudricV AudricV closed this as completed Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants