Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate gems for OpenSearch and Elasticsearch support #118

Open
1 task done
esmarkowski opened this issue Mar 31, 2024 · 0 comments
Open
1 task done

Create separate gems for OpenSearch and Elasticsearch support #118

esmarkowski opened this issue Mar 31, 2024 · 0 comments

Comments

@esmarkowski
Copy link
Member

esmarkowski commented Mar 31, 2024

With older version of stretchy-model it was relatively easy to provide common functionality between OpenSearch and Elasticsearch, however the features have started to diverge in pretty significant ways.

Additionally, elasticsearch-persistence has fallen behind and currently only supports Elasticsearch 7. This means the additional namespaces in the elasticsearch-api gem aren't available and is why we currently patch them into the client.

For opensearch-ruby it is a similar situation.

Pull Requests need to be made to use 'elasticsearch', '~> 8'

  • elasticsearch-rails
  • elasticsearch-persistence
  • elasticsearch-model

Pull Request for opensearch-ruby to add the namespaces for new features in 2.12

But that's not even the issue

I think we should be more explicit about what backend we're using with stretchy-model and break out support into separate plugin gems. This would help keep tests focused and allow stretchy-model to provide a unified interface for things like Opensearch's ml commons and Elasticsearch's ML implementation.

stretchy-elasticsearch
stretchy-opensearch

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant