Log pip install command output

[s0undt3ch]

How would this feature be useful?
Besides making it similar to tox(allowing for a smoother transition to nox), it's often useful in case of issues to, even though installing the requirements didn't fail, know which versions were actually installed.

Describe the solution you'd like
One solution would be do always show that output.
The other solution would be to add a --verbose boolean flag which, when passed, would additionally log the output of the pip install command (s0undt3ch@b5049ab)

Describe alternatives you've considered
The only alternative is "patching" nox or submitting a PR to fix/enhance nox.

[s0undt3ch]

This is particularly useful in CI contexts

[theacodes]

Don't we already show that output if anything goes wrong? I'm -1 for showing pip output always by default, it's incredibly noisy.

…

On Wed, Mar 13, 2019, 8:39 AM Pedro Algarvio ***@***.***> wrote: This is particularly useful in CI contexts — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#173 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc9RV_ZqzAmtXFfp65FekJLkAYaEHks5vWRvBgaJpZM4bthJ6> .

[s0undt3ch]

Only if something goes wrong, yes, if nothing goes wrong, we can never get that output.
I'm also -1 with always showing that output, but the additional flag to show the output of all commands? I'd go for that and that's what I did on a branch which I link above.
If that's accepted, I'll submit a PR.

[theacodes]

Yeah since it's plumbed through the normal run thing we should let users set that flag. Sounds good.

…

On Wed, Mar 13, 2019, 8:58 AM Pedro Algarvio ***@***.***> wrote: Only if something goes wrong, yes, if nothing goes wrong, we can never get that output. I'm also -1 with always showing that output, but the additional flag to show the output of all commands? I'd go for that and that's what I did on a branch which I link above. If that's accepted, I'll submit a PR. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#173 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc7eRvOxk8ONIl_4M8ox0jhIWI7h7ks5vWSAIgaJpZM4bthJ6> .

[s0undt3ch]

Ok, I'll submit a PR.

[erinwild]

See the comment I left on your PR for a way to achieve this currently:

It's already possible to override the silent flag in session.install (see #157). If the desired outcome is conditional reporting particularly in a CI context, the function in the noxfile could potentially handle this via extra arguments.

For example, nox -s tests -- verbose when additional verbosity is desired:

@nox.session(python='3.7')
def tests(session):
    verbosity = True if 'verbose' in session.posargs else False
    session.install('numpy', silent=verbosity)

[vaneseltine]

Was this closed by #174?

[theacodes]

Yeah I think so.