Using more specific regex in _resolved_interpreter().
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
commented
Aug 24, 2018
| parts = parts[:2] | ||
|
|
||
| self.interpreter = "python{}".format(".".join(parts)) | ||
| self.interpreter = "python{}".format(match.group("xy_ver")) |
There was a problem hiding this comment.
@theacodes I can save
xy_version = match.group("xy_ver")and then re-use it in the call to locate_via_py at line 131. Does that make the code too hard to read?
There was a problem hiding this comment.
OK turns out this is relevant for #100, so I'll just address it there and use this PR as a diffbase
theacodes
approved these changes
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.