Storing platform.system() as global in nox.virtualenv.
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also re-factoring unit tests to account for this change. This is a follow up to wntrblm#100.
theacodes
approved these changes
Aug 28, 2018
|
LGTM, but you gotta tribute some lint for the lint gods. (feel free to merge once it's passing) |
|
Woooo
…On Mon, Aug 27, 2018, 7:39 PM Danny Hermes ***@***.***> wrote:
Merged #124 <#124> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#124 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAPUc_GZ2slhfguoGK57u69lrqsVyVwgks5uVK19gaJpZM4WOhP6>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also re-factoring unit tests to account for this change. This is a follow up to #100.
Also some minor editorializing (switch usage of
dirtodir_as a variable name, shadowing builtins grumble grumble).