Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify Virtualenv.interpreter in _resolved_interpreter. #127

Merged
merged 1 commit into from Aug 28, 2018
Merged

Don't modify Virtualenv.interpreter in _resolved_interpreter. #127

merged 1 commit into from Aug 28, 2018

Conversation

dhermes
Copy link
Collaborator

@dhermes dhermes commented Aug 28, 2018

Also cache and re-use the result.

@dhermes dhermes mentioned this pull request Aug 28, 2018
Closed
@theacodes theacodes merged commit 4b78ebc into wntrblm:master Aug 28, 2018
@dhermes dhermes deleted the dont-modify-interpreter branch August 28, 2018 17:49
@dhermes
Copy link
Collaborator Author

dhermes commented Aug 28, 2018

Not very controversial, eh @theacodes?

@theacodes
Copy link
Collaborator

Nah I think the value of intepreter should be the same you specify to nox.session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhermes @theacodes