Allow not passing "--upgrade" to session.install
#172
Conversation
s0undt3ch
force-pushed
the
features/no-upgrade
branch
from
27eb112
to
aa6a548
Compare
|
This is a great point. I'm not sure why I ended up going with @dhermes WDYT? |
|
I think it should be off by default and have an |
nox/sessions.py
Outdated
| @@ -242,8 +242,11 @@ def install(self, *args, **kwargs): | |||
|
|
|||
| if "silent" not in kwargs: | |||
| kwargs["silent"] = True | |||
| upgrade = kwargs.pop("upgrade", True) | |||
There was a problem hiding this comment.
I am all for this but I'd make False the default
There was a problem hiding this comment.
That's a backwards incompatible change, but I'm cool with if you're cool with it too.
At that point we could just pass it through like every other pip parameter, e.g.: session.install("--upgrade", "-r", "requirements.txt") |
|
Ha, DERP. Good call |
|
Cool, sound good to you, @s0undt3ch? |
|
Sorry, just woke and now I read the whole list of comments. |
|
I'll update the PR. |
s0undt3ch
force-pushed
the
features/no-upgrade
branch
from
aa6a548
to
accd857
Compare
|
PR updated. |
|
Seems like some documentation needs to be updated as well: https://github.com/theacodes/nox/search?q=upgrade&unscoped_q=upgrade |
|
Docs updated. |
I don't really know the reasoning why `--upgrade` was added by default to the `pip` call in `session.install`. I reason against it, and such flag should be passed explictily
s0undt3ch
force-pushed
the
features/no-upgrade
branch
from
941e703
to
7bdfbb5
Compare
|
Thank you, @s0undt3ch! |
I don't really know the reasoning why
--upgradewas added by default to thepipcall insession.install.I would reason against it, but, since it has been the default, at least allow the user not to upgrade.