Add friendlier message if no noxfile.py #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #462. Add a friendlier message on the specific case that user is calling nox from within a directory with no noxfile. Existing test for this case modified and two additional tests added to ensure lower level errors are still handled further down.
cjolowicz
reviewed
Jul 6, 2021
nox/tasks.py
Outdated
Comment on lines
72
to
74
| except FileNotFoundError: | ||
| logger.error(f"noxfile.py not found in {noxfile_parent_dir!r}.") | ||
| return 2 |
There was a problem hiding this comment.
We need to generalize this error message for the case where the Noxfile is not named noxfile.py.
I'd suggest to use the exception handler for IOError below this one as a template:
Suggested change
| except FileNotFoundError: | |
| logger.error(f"noxfile.py not found in {noxfile_parent_dir!r}.") | |
| return 2 | |
| except FileNotFoundError: | |
| logger.error("Failed to load Noxfile {}: no such file".format(global_config.noxfile)) | |
| return 2 |
Replacing logger.exception with logger.error avoids the traceback.
There was a problem hiding this comment.
Good spot!, I'll tweak that now.
cjolowicz
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#462
Add a friendlier message on the specific case that user is calling
nox from within a directory with no noxfile.
Existing test for this case modified and two additional tests
added to ensure lower level errors are still handled further down.