Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Bot keeps adding the awaiting reviews label #10

Closed
3 of 9 tasks
dhruvmanila opened this issue Nov 23, 2020 · 0 comments
Closed
3 of 9 tasks

[bug] Bot keeps adding the awaiting reviews label #10

dhruvmanila opened this issue Nov 23, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@dhruvmanila
Copy link
Member

GitHub event:

  • pull_request:opened
  • pull_request:synchronize
  • pull_request:ready_for_review
  • pull_request:closed
  • pull_request:labeled
  • pull_request:unlabeled
  • pull_request_review:submitted
  • check_run:completed
  • issues:opened

Example pull request/issue:

TheAlgorithms/Python#3420

Steps to reproduce the bug:

  • Pull request has been opened, no errors found, and all tests passed => bot adds the awaiting reviews label
  • Then a maintainer approves the pull request and tries to remove the label awaiting reviews but the bot adds it back as it still thinks the review is pending.

Proposal:

The solution would be to remove the awaiting reviews label when a pull request has been approved and not add it back on the pull_request:unlabeled event.

The above example is a rare case because the bot was not installed when the pull request was opened, thus the bot did not add awaiting reviews label and so it thought the review was still pending.

@dhruvmanila dhruvmanila added the bug Something isn't working label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant