Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend adding a CountOfDivisors function to Algorithms.Numeric #382

Closed
deljohnson1 opened this issue Feb 12, 2023 · 4 comments
Closed
Assignees

Comments

@deljohnson1
Copy link
Contributor

Recommend adding a BigInteger CountOfDivisors(BigInteger n) function to Algorithms.Numeric.

Also recommend modifying DivisorsCountSequence.cs to use that function. Current algorithm of DivisorsCountSequence.cs is O(n) for each n, when it should be O(sqrt(n)).

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@siriak
Copy link
Member

siriak commented Apr 13, 2023

@deljohnson1 feel free to create a PR with the proposed fixes

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 14, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants