Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding Cycle detection in linked list code #714

Closed
garimamangal19 opened this issue Oct 24, 2020 · 14 comments
Closed

[FEATURE] Adding Cycle detection in linked list code #714

garimamangal19 opened this issue Oct 24, 2020 · 14 comments
Labels
enhancement New feature or request Stale

Comments

@garimamangal19
Copy link

Detailed Description

Context

Possible Implementation

@garimamangal19 garimamangal19 added the enhancement New feature or request label Oct 24, 2020
@Panquesito7
Copy link
Member

Please describe as much as possible about this algorithm. Thank you.

@bhavdeep009
Copy link

are you looking for the code which detects cycle in link list?

@Panquesito7
Copy link
Member

You haven't filled the template: it doesn't have description (not even detailed), context or possible implementation.
Please fill the template how does this algorithm work (or at least a description), context and possible implementation.

Thank you.

@ankitakul
Copy link

Hello, is this issue still open? I have a project for a software methodology class to contribute to an open source repo and I would like to work on this project. Could I be assigned to this issue?

Possible implementation: I was thinking of using 2 pointers, slow and fast. Slow pointer will move one step forward and fast pointer will move 2 steps forward. If they are pointing to same node, we know its a loop. If the fast reaches the null/end, it has no loop.

@Panquesito7
Copy link
Member

Panquesito7 commented Feb 13, 2021

Thank you for your interest in contributing. 👍
Before submitting a PR, please ensure the following:

  • The algorithm isn't a duplicate in this repository.
  • Make your code as per the repository standards.
  • Ensure all the automated-tests pass.

@ankitakul
Copy link

Hello, My code is ready. I made sure its not duplicate and according to standards. I am new to github and I am having issues pushing the code. It is saying invalid username and password , authentication failed for github/TheAlgorithms/C.git.
Is it because I am not assigned the issues? Can you please assign it to me.

@ayaankhan98
Copy link
Member

Hello, My code is ready. I made sure its not duplicate and according to standards. I am new to github and I am having issues pushing the code. It is saying invalid username and password , authentication failed for github/TheAlgorithms/C.git.
Is it because I am not assigned the issues? Can you please assign it to me.

No it has no relation with issue assignment. It is because of your improper login configuration for Github CLI.

@ankitakul
Copy link

Capture

I am getting this error now.

@Panquesito7
Copy link
Member

I am getting this error now.

You must fork the repository, then clone your forked repository. 🙂

@ankitakul
Copy link

I was able to create a pull request after forking the repository. Thank you very much for your support!! 😊

@Arjun-Dagar
Copy link

Can i work on it?

@Panquesito7
Copy link
Member

Can I work on it?

Sure, if you want. I'll review your PR as soon as possible. 🙂
Just follow the steps mentioned in this issue above here.

@github-actions
Copy link
Contributor

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 17, 2021
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

6 participants