Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our GitHub Action is testing github.com/tjgurwara99/Go/... not TheAlgorithms #271

Closed
cclauss opened this issue Feb 18, 2021 · 4 comments
Closed
Assignees
Labels

Comments

@cclauss
Copy link
Member

cclauss commented Feb 18, 2021

Describe the bug
@tjgurwara99
Our GitHub Action is testing github.com/tjgurwara99/Go/... not github.com/TheAlgorithms/Go/...

To Reproduce
Steps to reproduce the behavior:

  1. Look at the path in the output of our GitHub Actions go tests. We are testing tjgurwara99, instead of TheAlgorithms.

Expected behavior
A clear and concise description of what you expected to happen.
We test github.com/TheAlgorithms/Go/...

Screenshots
If applicable, add screenshots to help explain your problem.

Run go test $(go list ./... | grep -v /sbom | grep -v /rsa)
?   	github.com/tjgurwara99/Go/ciphers	[no test files]
ok  	github.com/tjgurwara99/Go/ciphers/caesar	0.016s
ok  	github.com/tjgurwara99/Go/ciphers/polybius	0.010s
ok  	github.com/tjgurwara99/Go/ciphers/rot13	0.005s
ok  	github.com/tjgurwara99/Go/ciphers/xor	0.006s

Additional context
Add any other context about the problem here.

@tjgurwara99
Copy link
Member

That's because of the go.mod - in hind sight I shouldn't have committed the file. The file should be updated to work with TheAlgorithm handle.

@cclauss
Copy link
Member Author

cclauss commented Feb 18, 2021

Can you please submit a PR to fix that and also upgrade go v1.14 --> v1.15 in go.mod ?

@tjgurwara99
Copy link
Member

Sure, will do that now.

@cclauss
Copy link
Member Author

cclauss commented Feb 18, 2021

Closed in #273

@cclauss cclauss closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants