Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect octave algorithm implementation #31

Closed
zaraken opened this issue Jun 15, 2020 · 1 comment
Closed

Incorrect octave algorithm implementation #31

zaraken opened this issue Jun 15, 2020 · 1 comment

Comments

@zaraken
Copy link

zaraken commented Jun 15, 2020

This is obviously incorrect.
According to implementation It's enough that the last pair of characters be the same to return true. However all pairs of characters need to be the same for the string to be considered a palindrome.

Would be nice if implementations came with tests.

@cozek
Copy link
Member

cozek commented Jun 17, 2020

You are right. Perhaps you could provide a correct implementation or give pointers on how to include some tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants