Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move compiler defaults from nim.cfg to config.nims #26

Closed
ZoomRmc opened this issue Jun 4, 2023 · 1 comment · Fixed by #47
Closed

chore: move compiler defaults from nim.cfg to config.nims #26

ZoomRmc opened this issue Jun 4, 2023 · 1 comment · Fixed by #47
Labels
enhancement New feature or request needs upstream fix Issue depends on the Nim compiler/TheAlgorithms website

Comments

@ZoomRmc
Copy link
Contributor

ZoomRmc commented Jun 4, 2023 •
edited

At this moment, in some cases setting the default gc/mm setting for the compiler results in a compilation error.
The workaround for this is moving the setting to the nim.cfg file. Having an additional configuration file is not great, so as soon as the fix for the bug lands in stable the setting should be moved back to the config.nims and nim.cfg should be removed.

This is a PR that sould have fixed the issue: nim-lang/Nim#19455. Not sure why we're still hitting it.
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 8, 2023
@dlesnoff
Copy link
Collaborator

Not sure why we're still hitting it.

The compilation error was obtained with Nim 1.6.12 from the post of @vil02 that you linked.
Is it still hit on Nim-devel? If so, please open an issue in the Nim repository and link it here.

@dlesnoff dlesnoff added the needs upstream fix Issue depends on the Nim compiler/TheAlgorithms website label Jun 20, 2023
@ZoomRmc ZoomRmc mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs upstream fix Issue depends on the Nim compiler/TheAlgorithms website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: gc->mm, move back to config.nims, fixes #26 ZoomRmc/TheAlgorithmsNim
3 participants
@ZoomRmc @Panquesito7 @dlesnoff