Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: QuickSelect test case is failing #169

Closed
dev-madhurendra opened this issue Oct 2, 2023 · 4 comments · Fixed by #207
Closed

[BUG]: QuickSelect test case is failing #169

dev-madhurendra opened this issue Oct 2, 2023 · 4 comments · Fixed by #207
Labels
bug Something isn't working

Comments

@dev-madhurendra
Copy link
Contributor

Motivation

Quick Select test case is failing due to this overall PR builds is failing.
Need to fix that !

Screenshot from 2023-10-02 21-21-28

Examples

No response

Possible workarounds

No response

@dev-madhurendra dev-madhurendra added the enhancement New feature or request label Oct 2, 2023
@appgurueu appgurueu added bug Something isn't working and removed enhancement New feature or request labels Oct 2, 2023
@appgurueu appgurueu changed the title [FEATURE]: QuickSelect test case is failing [BUG]: QuickSelect test case is failing Oct 2, 2023
@dev-madhurendra
Copy link
Contributor Author

dev-madhurendra commented Oct 3, 2023

Hi @appgurueu ,
I think we have to ask or assign @prisojacques to resolve this bug he added the code of quick select.
and this issue should be high priority (because every PR's build are failing due to this.)
What's you views on this ?

@appgurueu
Copy link
Contributor

appgurueu commented Oct 3, 2023

Hi @appgurueu , I think we have to ask or assign @prisojacques to resolve this bug he added the code of quick select. and this issue should be high priority (because every PR's build are failing due to this.) What's you views on this ?

I'm not sure @prisojacques is responsible; the regressions seems to have been introduced by the switch to a random pivot selection strategy (4db3278). I've made quick "fix" PR that just reverts that commit for now. I'll take a closer look later.

@vladimir-cucu
Copy link
Contributor

Hi @appgurueu , I think I've managed to fix this issue in #207 . I've described in more details why I've made each respective change inside my PR. If you have some free time, I would appreciate if you can take a look over it. 😊

@dev-madhurendra
Copy link
Contributor Author

Thank You @vladimir-cucu !
@appgurueu @raklaptudirm please look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants