Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Shown contributors are wrong #146

Closed
appgurueu opened this issue Dec 24, 2021 · 6 comments
Closed

[BUG] Shown contributors are wrong #146

appgurueu opened this issue Dec 24, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@appgurueu
Copy link
Contributor

appgurueu commented Dec 24, 2021

Description of the bug

Contributors are wrong, see https://the-algorithms.com/de/algorithm/linked-stack - it shows only a Lua implementation, yet 4 contributors are shown which haven't contributed to the Lua repo at all.

@appgurueu appgurueu added the bug Something isn't working label Dec 24, 2021
@Panquesito7
Copy link
Member

Hey there! That's because that's multiple implementations in multiple languages for that algorithm are added, so in total it would be 4 contributors to that algorithm. Correct me if I'm wrong. 🙂

@appgurueu
Copy link
Contributor Author

appgurueu commented Dec 24, 2021

Hey there! That's because that's multiple implementations in multiple languages for that algorithm are added, so in total it would be 4 contributors to that algorithm. Correct me if I'm wrong.

Then why doesn't it shown the "other" implementations?

@Panquesito7
Copy link
Member

Hey there! That's because that's multiple implementations in multiple languages for that algorithm are added, so in total it would be 4 contributors to that algorithm. Correct me if I'm wrong.

Then why doesn't it shown the "other" implementations?

Other implementations of that same algorithm? It'll only display the explanation from the Algorithms-Explanation repository if provided. Aliases will also show one implementation if set in the settings. I hope I get to understand. :)

@appgurueu
Copy link
Contributor Author

Hey there! That's because that's multiple implementations in multiple languages for that algorithm are added, so in total it would be 4 contributors to that algorithm. Correct me if I'm wrong.

Then why doesn't it shown the "other" implementations?

Other implementations of that same algorithm? It'll only display the explanation from the Algorithms-Explanation repository if provided. Aliases will also show one implementation if set in the settings. I hope I get to understand. :)

Bildschirmfoto von 2021-12-24 20-56-29

This is what it currently looks like. Indisputably misleading.

@maltejur
Copy link
Collaborator

Yeah that is not what it should look like, I'll look into it

@maltejur
Copy link
Collaborator

Ok funny thing there actually once existed a linked_stack.py which later got renamed to stack_with_singly_linked_list.py.

image
image

But the previous commits of course still got counted for linked_stack.py so here they are. I would argue that this is such a niche problem that it isn't worth looking into more, especially with the possible changes planned to the website which we discussed in the discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants