Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable behaviour while catching thumbs (with mpv) #3

Closed
waxfingers opened this issue Dec 6, 2017 · 4 comments
Closed

Unstable behaviour while catching thumbs (with mpv) #3

waxfingers opened this issue Dec 6, 2017 · 4 comments

Comments

@waxfingers
Copy link

waxfingers commented Dec 6, 2017

Till the thumbnails' caching is done, a "ghost instance" of mpv jumps like crazy in the dock; till all thumbs are generated it is impossible to access mpv in fullscreen mode as it just keeps changing space (screen). This behaviour happens both in shorter than 3600" videos and in longer ones - script trigered by keybind. NOT the case if using ffmpeg as per lua seting conf.

mpv 0.27.0
OSX 10.11.6
mpv_thumbnail_script 0.3.0

Have to say, great plug!! Congrats and thank you =)

@TheAMM
Copy link
Owner

TheAMM commented Dec 6, 2017

Hmm. This is because mpv is being called in the background.
I don't have a Mac to test on (and don't know much about the ecosystem), so this could get complicated.

So let's try the first thing I can come up with.
Please edit the mpv_thumbnail_script_server.lua near line 417, adjust it as follows:

diff --git a/mpv_thumbnail_script_server.lua b/new.lua
index 6a9686e..94e00ab 100644
--- a/mpv_thumbnail_script_server.lua
+++ b/new.lua
@@ -417,6 +417,7 @@ function create_thumbnail_mpv(file_path, timestamp, size, output_path)
         "mpv",
         -- Hide console output
         "--msg-level=all=no",
+        "--player-operation-mode=cplayer",
         file_path,
 
         -- Disable ytdl

(Add the "--player-operation-mode=cplayer", without the leading +)

This might fix it, so fingers crossed.

@waxfingers
Copy link
Author

waxfingers commented Dec 7, 2017

I'm afraid it did not... but got it a bit narrowed down; it only occurs when opening the files by double clicking them in the finder, from the terminal behaviour is ok, I disabled all other scripts, plugs and settings to be sure. OT but just thought it could be useful to have a settings to choose IF automatically delete thumbs from temp once video is closed.

@Akemi
Copy link

Akemi commented Dec 7, 2017

this should be fixed with the next mpv release. the fix is currently only in mpv master.

@TheAMM
Copy link
Owner

TheAMM commented Dec 7, 2017

Closing this in advance unless something new pops up.

@TheAMM TheAMM closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants