Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request #4

Closed
pavelxdd opened this issue Dec 7, 2017 · 3 comments
Closed

feature request #4

pavelxdd opened this issue Dec 7, 2017 · 3 comments

Comments

@pavelxdd
Copy link

pavelxdd commented Dec 7, 2017

Hello.

  1. Can you add a script option to enable --no-config argument? The script stucks on generating thumbnails unless I add this argument to server.lua.

  2. Could be useful to have an option to specify --profile argument with specific profile name for generating thumbnails.

@TheAMM
Copy link
Owner

TheAMM commented Dec 8, 2017

Sure, but can you elaborate on the stuck generation?
Platform, config file?

@pavelxdd
Copy link
Author

pavelxdd commented Dec 8, 2017

Windows 10, x64
config: http://sprunge.us/XIZM

can you elaborate on the stuck generation?

Strange thing, I can't reproduce it today. I swear yesterday without adding no-config it just didn't generate thumbnails at all, the counter above the thumbnail placeholder stayed at zero, or very close to zero (10/380 for example), and didn't increase. There were no errors in console other than messages that the thumbnail size isn't the same as before and should be regenerated.

@TheAMM
Copy link
Owner

TheAMM commented Dec 8, 2017

Well, I added some extra logging behind a new option, so if it happens again you can get logs out of each sub-mpv call.
The script overall is fairly robust, but it lacks proper error logging (it doesn't really try to figure out what went wrong, just that something went wrong and we should bail).

@TheAMM TheAMM closed this as completed in a0ad304 Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants