-
Notifications
You must be signed in to change notification settings - Fork 101
Logstash v5 Support #35
Comments
Updated to api 2 in 8d27e0f |
https://github.com/logstash-plugins/logstash-output-elasticsearch/blob/exponential-threadsafe/lib/logstash/outputs/elasticsearch/common.rb appears to be the implementation that logstash prefers. Based on that, my TODO notes:
|
e32b6e9 removes Stud::Buffer, keeps max_exceptions counter for a set of events, adds better support for recovering from batched insert failures. Missing tests. |
Notes for myself. Currently discovering the pain from the JDBC batch behaviour. Includes, but not limited to:
Since the plugin may be used with any JDBC-compatible engine, it may be just safer for each event to be processed as a single command (like unsafe goes through), and batches go in the bin 😞 |
Batched SQL now in the bin. TODO: Tests for new test cases. |
Shower thought: Do we actually want to retry any non-connection related JDBC exceptions. Most seem to be fatal errors that without human intervention won't resolve by retrying. Retryable states by class:
Counter thought: JDBC drivers are inconsistent, and have their own SQLSTATE codes. Also May throw an SQL exception when they dont mean to (do we even care about this?). What's worse? Holding up the pipeline, or just losing a few events. |
Added custom retry_sql_states configuration. Currently this is the full sql state code, not the class. |
Closing for individual issues going forward. |
Logstash v5 will be out Soon(TM).
Known, possibly incomplete things to alter
logstash-core-plugin-api dependency - Mass update plugins for 5.0.0 release elastic/logstash#4829Stud::Buffer replacement with multi_receiveException handling - how many exceptions are really actually re-tryable?The text was updated successfully, but these errors were encountered: