Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot announcement bug #60

Closed
3 of 4 tasks
VortexLife opened this issue Nov 6, 2017 · 10 comments
Closed
3 of 4 tasks

Bot announcement bug #60

VortexLife opened this issue Nov 6, 2017 · 10 comments
Labels
🐞 Bug Something isn't working with Bastion Not Enough Information Further information is requested

Comments

@VortexLife
Copy link

VortexLife commented Nov 6, 2017

Prerequisites

Description

This is the error i get whenever i use it, it only started to do it when i linked it to a channel,
Also the part where it said "Test" is when i get the issue, if i do it in a line it works fine, but the moment it creates a new line is when i start to get the errors

Example !announce Hello world. (Works fine

Example !Announce
Hello world. (does not work)

But i was able to do the 2nd example before perfectly fine
untitled

Then i done !announcementChannel [channel name] and now i cant do an announcement like i did the 2nd example (Top picture)

untitled

Steps to Reproduce

  1. Run the !announcementChannel command
  2. Run
!announce line1
line2
  1. See the console

Expected behavior:
It should post the announcement message.

Actual behavior:
The error you get when trying is this:

{ SyntaxError: Invalid or unexpected token
    at Client._eval (D:\Discord Bots\Bastion\node_modules\discord.js\src\client\Client.js:493:17)
    at ShardClientUtil._handleMessage (D:\Discord Bots\Bastion\node_modules\discord.js\src\sharding\ShardClientUtil.js:109:76)
    at emitTwo (events.js:131:20)
    at process.emit (events.js:214:7)
    at emit (internal/child_process.js:772:12)
    at _combinedTickCallback (internal/process/next_tick.js:141:11)
    at process._tickCallback (internal/process/next_tick.js:180:9) name: 'SyntaxError' }
Trace
    at Object.exports.error.message [as error] (D:\Discord Bots\Bastion\handlers\logHandler.js:31:11)
    at Object.exports.run (D:\Discord Bots\Bastion\modules\owner\announce.js:63:17)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
[/ERROR]

Reproduces how often:
100% of the time.

Additional Information

Any additional information, screenshots, configuration or data that might be necessary to reproduce the issue, if any.

Versions

  • Bastion version: 6.0.0
  • Operating System (including version): Windows 10 x64-bit
  • Node.js version: 8.9.0
  • npm version: 5.5.1
@iamtraction iamtraction added the Not Enough Information Further information is requested label Nov 6, 2017
@iamtraction
Copy link
Member

Your issue didn't provided much information, so I just tried to set the announcement channel using the announcementChannel command, and then used the announce command to send out an announcement. And both of the commands worked fine for me (as you can see in the screenshot below).

Example of announce command

And please edit your issue and fill out the required fields. There's a reason it's been given as a template, to help us in reproducing the error you get and analyzing why it happens and try appropriate fix. And without more information, we can't know why that actually happened.
So please fill out the above details and I'll see why you're getting that error. Then I can work on the fix, if it's actually an error.

@VortexLife
Copy link
Author

VortexLife commented Nov 6, 2017

This is the error i get whenever i use it, it only started to do it when i linked it to a channel,
Also the part where it said "Test" is when i get the issue, if i do it in a line it works fine, but the moment it creates a new line is when i start to get the errors

Example !announce Hello world. (Works fine

Example !Announce
Hello world. (does not work)

But i was able to do the 2nd example before perfectly fine
untitled

Then i done !announcementChannel [channel name] and now i cant do an announcement like i did the 2nd example (Top picture)

untitled

@iamtraction
Copy link
Member

  1. Run the announcementChannel command.
  2. Then run announce Test.

And send the screenshot of both Discord as well as the console.

@VortexLife
Copy link
Author

2
untitled

@iamtraction
Copy link
Member

Seems like that works!

@VortexLife
Copy link
Author

I think you're failing to see what i'm trying to say

for instance doing it in a line

!announce test. This command works fine

!announce (Forget this line and look below)
test

The 2nd one I'm trying to use, which worked fine before (Top picture above with the rules/ info
now that i set the channel the bottom line isn't working so i cant use
!announce
test

The reason why I'm trying to use the 2nd line is because i use it to post big announcements
But even at that the minute i go into a 2nd line anyway i get that error once again no files were touched nor did i change anything that requires the announcements.

@iamtraction
Copy link
Member

Okay, I understand now. You never mentioned that it failed while using multiple lines. I get it now. Will look into it and fix it right now.

By the way, if you just filled up the required fields in the issue template I could have understood it. That's the exact reason why the issue template is provided. Just keep that in mind next time, so we can understand you better in the first time. 😄

@VortexLife
Copy link
Author

Oh i wasn't having a go i figured i failed to say it properly so tried to break it down haha, Thanks for looking into it really appreciated :)

Also i kinda explained it at the start :P but no big deal 😄

"Example !announce Hello world. (Works fine)

Example !Announce
Hello world. (does not work)"

@iamtraction
Copy link
Member

I didn't saw your edited message before I posted that message. Anyways, no problem.

@VortexLife
Copy link
Author

Thank you that works 👍

@iamtraction iamtraction added the 🐞 Bug Something isn't working with Bastion label Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working with Bastion Not Enough Information Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants