Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): add LoginManager.logOut + AccessToken mocks #223

Merged
merged 2 commits into from Apr 7, 2022

Conversation

Andarius
Copy link
Contributor

@Andarius Andarius commented Apr 7, 2022

Fix issue where jest.spyOn(LoginManager, 'logOut') would raise Cannot spy the logOut property because it is not a function; undefined given instead

Fix issue where `jest.spyOn(LoginManager, 'logOut')` would raise `Cannot spy the logOut property because it is not a function; undefined given instead`
@Andarius Andarius changed the title Adding missing logOut mock fix(jest): adding missing logOut mock Apr 7, 2022
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you
Don't worry about the conventional commit CI job, that's a quirk of the way GitHub does merges and is just a warning to maintainers at this point to be careful at the merge

@mikehardy mikehardy added the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Apr 7, 2022
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously looked good to me, now even better ;-). You want me to hang on while you check through other stuff or you want me to merge as soon as CI goes green?

@Andarius
Copy link
Contributor Author

Andarius commented Apr 7, 2022

Hey @mikehardy, I think I covered everything I needed, all my tests are passing now. I made a patch while waiting for a release so up to you :)

@mikehardy mikehardy changed the title fix(jest): adding missing logOut mock fix(jest): add LoginManager.logOut + AccessToken mocks Apr 7, 2022
@mikehardy mikehardy merged commit 5ba05f3 into thebergamo:master Apr 7, 2022
@mikehardy mikehardy removed the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Apr 7, 2022
@Andarius Andarius deleted the patch-1 branch April 7, 2022 15:23
github-actions bot pushed a commit that referenced this pull request Apr 18, 2022
## [8.0.0](v7.3.3...v8.0.0) (2022-04-18)

### ⚠ BREAKING CHANGES

* **sdks:** this version uses new major versions of the underlying SDKs and has breaking changes:

- iOS mininum target now 11, alter your Podfile and in project.pbxproj as needed
- Xcode 13+ required going forward. Xcode 12 not supported
- Share dialog description and title were deprecated in v12,  removed now
- Client access token required: configure on Facebook console and in the app
- GMS AD_ID Android Permission added by native SDK by default, use AndroidManifest tools:remove if unwanted

Please note the Expo config plugin has not been updated yet to handle client access token, use v12 if you need Expo config plugins. Follow #228 for updates or post a PR if this is important to you. Thanks!

### Features

* **sdks:** Update to v13 of native SDKs ([#221](#221)) ([493a638](493a638))

### Bug Fixes

* **jest:** add LoginManager.logOut + AccessToken mocks ([#223](#223)) ([5ba05f3](5ba05f3))
@github-actions
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants