New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): ShareDialog.setMode('native') throws in Turkish language #240
fix(android): ShareDialog.setMode('native') throws in Turkish language #240
Conversation
…e contains letter i
android/src/main/java/com/facebook/reactnative/androidsdk/FBShareDialogModule.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Hardy <github@mikehardy.net>
Oh no hahah - there are a lot of them!
This only fixes 1 of the remaining 7, do you have this checked out locally in order to change the rest or were you just using the web UI? I can change the rest if you don't actually have it checked out etc |
some toLowerCase also
|
Haha I was also going to report those. Good job! |
I only used web UI. Would be great if you did those. |
Okay - I'll pull your PR locally and patch up the rest then we can fix this :-). Thanks for noticing it! The fix is easy - noticing it is clearly the hard part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got them all now!
### [8.0.1](v8.0.0...v8.0.1) (2022-04-30) ### Bug Fixes * **android:** ShareDialog.setMode('native') throws in Turkish language ([#240](#240)) ([30d9dd3](30d9dd3))
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #239
Test Plan:
I don't think it needs a test case, but I can provide one if necessary