Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update React-Core pod #42

Merged
merged 2 commits into from
May 27, 2021
Merged

fix: update React-Core pod #42

merged 2 commits into from
May 27, 2021

Conversation

philly25
Copy link
Contributor

This is apparently needed for Xcode 12 compatibility

Reference: facebook/react-native#29633

@philly25 philly25 changed the title Update React-Core pod fix: update React-Core pod May 25, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - this is the same one patched in to most of the modules I work on - just one unrelated nit to bump the react-native peerdep even higher, if @thebergamo agrees?

package.json Outdated Show resolved Hide resolved
@mikehardy mikehardy requested a review from thebergamo May 25, 2021 19:30
Co-authored-by: Mike Hardy <github@mikehardy.net>
@thebergamo thebergamo merged commit a1e1141 into thebergamo:master May 27, 2021
github-actions bot pushed a commit that referenced this pull request May 27, 2021
# [4.3.0](v4.2.0...v4.3.0) (2021-05-27)

### Bug Fixes

* compileDebugJavaWithJavac ([#31](#31)) ([913e792](913e792))
* update React-Core pod ([#42](#42)) ([a1e1141](a1e1141))

### Features

* **ios, sdk:** upgrade to FBSDK version 9.3.x ([#45](#45)) ([b2ea364](b2ea364))
@github-actions
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants