Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios, sdk): upgrade to FBSDK version 9.3.x #45

Merged
merged 2 commits into from
May 27, 2021

Conversation

bcomeau
Copy link
Contributor

@bcomeau bcomeau commented May 26, 2021

Fix issue #44

@mikehardy mikehardy changed the title Upgrade to FBSDK version 9.3.x feat(ios, sdk): upgrade to FBSDK version 9.3.x May 26, 2021
@mikehardy
Copy link
Collaborator

Seems fine - is there anything similar required for android to get it current https://github.com/facebook/facebook-android-sdk/releases (9.1.1) vs current default of 9.0.x

def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '9.0.+')

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I made the PR title "conventional" (Angular conventional commits format) and approved the CI run

@bcomeau
Copy link
Contributor Author

bcomeau commented May 26, 2021

Seems fine - is there anything similar required for android to get it current https://github.com/facebook/facebook-android-sdk/releases (9.1.1) vs current default of 9.0.x

def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '9.0.+')

Maybe changing
def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '9.0.+')
to
def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '9.3.+')

And then run the CI 🤞

@mikehardy
Copy link
Collaborator

9.1.1 is current for android, so 9.3 would not fly :)

CI on this change failed


[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit":
  In snapshot (Podfile.lock):
    FBSDKShareKit (= 9.0.1, ~> 9.0.1)

  In Podfile:
    react-native-fbsdk-next (from `../../`) was resolved to 4.2.0, which depends on
      react-native-fbsdk-next/Share (= 4.2.0) was resolved to 4.2.0, which depends on
        FBSDKShareKit (~> 9.3)

You need to update Podfile.lock on the example as well, but that's tedious, the example should just delete Podfile.lock before running

If you edited this line:

run: cd example/ios && pod install

To be this command cd example/ios && rm -f Podfile.lock && pod install vs the existing one, it should work

@thebergamo
Copy link
Owner

Lgtm as well 😬

@thebergamo thebergamo merged commit b2ea364 into thebergamo:master May 27, 2021
github-actions bot pushed a commit that referenced this pull request May 27, 2021
# [4.3.0](v4.2.0...v4.3.0) (2021-05-27)

### Bug Fixes

* compileDebugJavaWithJavac ([#31](#31)) ([913e792](913e792))
* update React-Core pod ([#42](#42)) ([a1e1141](a1e1141))

### Features

* **ios, sdk:** upgrade to FBSDK version 9.3.x ([#45](#45)) ([b2ea364](b2ea364))
@github-actions
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants