-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios, sdk): upgrade to FBSDK version 9.3.x #45
Conversation
Seems fine - is there anything similar required for android to get it current https://github.com/facebook/facebook-android-sdk/releases (9.1.1) vs current default of 9.0.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I made the PR title "conventional" (Angular conventional commits format) and approved the CI run
Maybe changing And then run the CI 🤞 |
9.1.1 is current for android, so 9.3 would not fly :) CI on this change failed
You need to update Podfile.lock on the example as well, but that's tedious, the example should just delete Podfile.lock before running If you edited this line:
To be this command |
Lgtm as well 😬 |
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fix issue #44