New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 & 9 autoscroll issue #89
Comments
... in the newest version from Swipe2 autoscroll is working also with IE -> tested ;) |
Thanks, but it still does not work in IE8 & 9 with the latest Swipe2 update. The carousel hangs on the second slide/div. |
I am having the same problem as @sjferwerda |
Ok. I had my programmer look at the js file and it seems he has fixed it the issue. All he had to do was comment out a line in the swipe.js file. Code before he commented it out:
Code after he commented it out:
My programmer told me that he is a bit reluctant to do this, because he is not sure if there is a specific reason for the above specified line of code. At this point, it looks to us like it is an oversight, but we would be very grateful for some verification. I tested in IE7, 8 & 9 and it works great now! \o/ Side note: Never mind issues explained in my previous post with the prev & next buttons. It seems to have fixed itself :-P |
Hmm, glad that it worked for you, but it still does not seem to be working for me at: |
Had the same problem. Added the following at the end of the next(delay) method: if (this.delay) this.begin(); Still works fine in Firefox and corrected the issue for me in IE. |
This works great egandalf! Thanks for save a morning of misery :) |
The only problem I've found - and it looks to be intentional in the code - is that the cycle doesn't stop correctly when you trigger a prev() or next() except in IE. :S I think removing a conditional, as mentioned in one of the previous posts, will help that. I'll test and post my findings. |
Ok, so adding the line to next() is good. Comment out the same line in onTransitionEnd(). Complete next() method: Complete onTransitionEnd() method: |
Thanks so much for everyone's work on this. The suggested fix/fixes appear to have solved the "autoscroll stops after second slide" issue. I still am seeing a bug in IE8 and do not know if it's part of Swipe or related to how I've implemented Swipe. In any case, what's happening is that once autoscroll tries to advance past the last slide and to the beginning again, it stops and an empty div/white box appears. All other functionality works fine in IE8. Probably not a deal breaker since most people won't even be allowing the autoscroll to advance past the first few slides, but still an annoyance. |
I'm using Swipe2 on the following page: http://www.greeleytribune.com/News/ and it works great with just about every important browser except for IE8 & IE9. In those two browsers, the autoscroll stops after the 2nd slide. I'm not seeing any errors in the console and I can advance to the next slide with next(). My code needs some refactoring, but I've even tried a barebones implementation and have had no luck.
I know that the focus of Swipe is not IE, but Swipe2 says that it does support IE. So, just wondering if anyone else has run into this issue or perhaps Swipe2 supports IE with the exception that the autoscroll doesn't work.
Thanks!
The text was updated successfully, but these errors were encountered: