Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe 2 not setting up styles correctly #55

Closed
chrisfrancis27 opened this issue Apr 4, 2012 · 3 comments
Closed

Swipe 2 not setting up styles correctly #55

chrisfrancis27 opened this issue Apr 4, 2012 · 3 comments

Comments

@chrisfrancis27
Copy link

Hey

I need to dynamically add/remove swipe at runtime, so I'm using swipe 2 as I notice you've added a kill method to perform teardown. Unfortunately, using swipe 2 with the exact same initialisation as swipe 1, the styles on the container <ul> are not being applied:

var $wrapper = $('.mod-heroBox-inner');
if (useSwipe) {
    swipe = new Swipe($wrapper[0]);
}

Namely, the width of the <ul> is not being set as it was in swipe 1 (the width of an <li> multiplied by the number of list items). However, it looks like the styles for the <li> elements themselves are being applied.

Lemme know if that makes no sense, or if you need a test case! :)

Chris

@thebird
Copy link
Owner

thebird commented Apr 5, 2012

Swipe 2 is in the middle of some initialization adjustments. The final API will be released shortly for Swipe 2.

@thebird
Copy link
Owner

thebird commented Apr 15, 2012

Swipe 2 is now back to the same initialization elements as Swipe 1. See the README on the Swipe 2 branch.

@thebird thebird closed this as completed Apr 15, 2012
@chrisfrancis27
Copy link
Author

Thanks Brad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants