Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to build with Java 20 #97

Closed
jump-kick opened this issue Oct 25, 2023 · 3 comments · Fixed by #98
Closed

Not able to build with Java 20 #97

jump-kick opened this issue Oct 25, 2023 · 3 comments · Fixed by #98
Assignees
@theborakompanioni
Labels
bug Something isn't working build Changes regarding the build process dependencies Added/Updated/Removed dependencies

Comments

@jump-kick
Copy link
Contributor

jump-kick commented Oct 25, 2023 •
edited

bitcoin-spring-boot-starter/readme.md

Line 117 in fa324a3

- java >=17

For a while I tried doing the Gradle build of the project using Java 20, but was only able to build it when I switched to Java 17. Is there a maximum Java version?
@theborakompanioni theborakompanioni added dependencies Added/Updated/Removed dependencies build Changes regarding the build process labels Oct 25, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 25, 2023
@theborakompanioni theborakompanioni added the bug Something isn't working label Oct 25, 2023
@theborakompanioni theborakompanioni mentioned this issue Oct 25, 2023
Merged
@theborakompanioni
Copy link
Owner

Hey @jump-kick, thanks for the report, brother 🧡

I assume this has to do with lombok. Can you verify that #98 works for you? This will test the build with Java 21, which is a LTS release and should be supported. I have not tested it with Java 20, but I suppose it will work too.

Appreciate any and all feedback. Thank you 🙏

@jump-kick
Copy link
Contributor Author

Thanks for the response! I will verify it, but I'm having trouble checking out the java21 branch for some reason. Will let you know ASAP

@jump-kick
Copy link
Contributor Author

You must have been right about Lombok! Yes, the build works on Java 20! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theborakompanioni theborakompanioni

Labels
bug Something isn't working build Changes regarding the build process dependencies Added/Updated/Removed dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(workflows): run with java 21 theborakompanioni/bitcoin-spring-boot-starter
2 participants
@theborakompanioni @jump-kick