-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add images for ARM architecture #21
Comments
I had multi-architecture on my list. I’m using the Docker Hub auto build though, so I’m going to have to figure out how to do it that way. Now that I know it’s needed I’ll spend time to work it out. |
Happy to help out if you need it |
I’ll take you up on that! I’m guessing it a change to the hooks build? |
Sounds great. I've never used hooks before, but I'm happy to learn |
I spent a bit of time playing with this, trying to make it work with Docker Cloud builds. I tried just altering the build hook, but that just generates an error message on DockerHub. I managed to get something working using GitHub Workflows, but it complicates other things. |
I just learned about Docker Mods. I think this is going to be a better way to go overall. I'm going to start playing with this is my other repo first, but I'll get back to here once I get everything working. |
@patrickjmcd, please try my latest Docker Mods build here. Instead of the |
I'll give this a shot this evening! |
I tried running the image on an arm64 machine and got |
@patrickjmcd, you used the original Linuxserver.io container with the DOCKER_MODS variable, right? Just asking because this is a totally different method than before. |
Just to tie this one up, I spoke with the guys at Linuxserver.io, and they got me me realize that with their Docker Mods there's no reason to try to build other architectures for simple script mods (which this is). The base image is multi-arch, and then the mod is dynamically pulled and my script does what is needs on whatever architecture it is running on (x86, Arm, whatever is supported by the base image). |
Currently the dockerhub images are
amd64
only. Using buildx would allow multi-architecture builds.For example, I was able to clone this repo and run
docker buildx build --platform linux/arm/v7,linux/arm64/v8,linux/amd64 --tag patrickjmcd/lidarr:latest --push .
to build a multi-arch image
The text was updated successfully, but these errors were encountered: