Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for ARM architecture #21

Closed
patrickjmcd opened this issue Sep 10, 2020 · 11 comments
Closed

Add images for ARM architecture #21

patrickjmcd opened this issue Sep 10, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@patrickjmcd
Copy link

Currently the dockerhub images are amd64 only. Using buildx would allow multi-architecture builds.

For example, I was able to clone this repo and run

docker buildx build --platform linux/arm/v7,linux/arm64/v8,linux/amd64 --tag patrickjmcd/lidarr:latest --push .

to build a multi-arch image

@TheCaptain989
Copy link
Owner

I had multi-architecture on my list. I’m using the Docker Hub auto build though, so I’m going to have to figure out how to do it that way. Now that I know it’s needed I’ll spend time to work it out.

@TheCaptain989 TheCaptain989 self-assigned this Sep 11, 2020
@TheCaptain989 TheCaptain989 added the enhancement New feature or request label Sep 11, 2020
@patrickjmcd
Copy link
Author

Happy to help out if you need it

@TheCaptain989
Copy link
Owner

I’ll take you up on that! I’m guessing it a change to the hooks build?
Anyway, I can add you to the project if you want to take it.

@patrickjmcd
Copy link
Author

Sounds great. I've never used hooks before, but I'm happy to learn

@TheCaptain989
Copy link
Owner

TheCaptain989 commented Sep 13, 2020

I spent a bit of time playing with this, trying to make it work with Docker Cloud builds. I tried just altering the build hook, but that just generates an error message on DockerHub. I managed to get something working using GitHub Workflows, but it complicates other things.
I've added you as a contributor. Maybe you'll have better luck than I did.

@TheCaptain989
Copy link
Owner

I just learned about Docker Mods. I think this is going to be a better way to go overall. I'm going to start playing with this is my other repo first, but I'll get back to here once I get everything working.

@TheCaptain989
Copy link
Owner

@patrickjmcd, please try my latest Docker Mods build here. Instead of the :latest tag, though, use :arm64. I don't have an ARM system to test this on, but I'm very curious if this works for you.

@patrickjmcd
Copy link
Author

I'll give this a shot this evening!

@patrickjmcd
Copy link
Author

I tried running the image on an arm64 machine and got Error: failed to generate container "fda4b2f1c8cdb035c21dd5b04fe1283e7b46ba2bdcc74a7aaadaaa2cdc7cf3e4" spec: │ │ no command specified

@TheCaptain989
Copy link
Owner

TheCaptain989 commented Oct 12, 2020

@patrickjmcd, you used the original Linuxserver.io container with the DOCKER_MODS variable, right? Just asking because this is a totally different method than before.

@TheCaptain989
Copy link
Owner

Just to tie this one up, I spoke with the guys at Linuxserver.io, and they got me me realize that with their Docker Mods there's no reason to try to build other architectures for simple script mods (which this is). The base image is multi-arch, and then the mod is dynamically pulled and my script does what is needs on whatever architecture it is running on (x86, Arm, whatever is supported by the base image).
I'm going to rework my Travis CI YAML build script to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants