Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter links-proxy encodes special urls with html instead of percent-based #394

Closed
ghost opened this issue Nov 7, 2021 · 5 comments
Closed
Labels

Comments

@ghost
Copy link

ghost commented Nov 7, 2021

example (of https://changelog.com/news/its-all-gravy-53Pa )

https://email.changelog.com/t/t-i-cddnly-qduttcki-nd/

  • current: => https://chris.manson.ie/it's-all-gravy
  • supposed: => https://chris.manson.ie/it%27s-all-gravy/
@jerodsanto
Copy link
Member

Thanks for the report! This has something to do with how Phoenix.HTML.Link.link/2processes our news item links when we send them to it in our news issue templates:

<h2 class="news_item-title"><%= link(@item.headline, to: @item.url) %></h2>

Not sure what/if anything we can do about it as a user of that API, but happy to learn!

@jerodsanto jerodsanto added the bug label Nov 8, 2021
@ghost
Copy link
Author

ghost commented Nov 8, 2021

make different pipeline for email links 🤷?

@gerhard
Copy link
Member

gerhard commented Aug 23, 2022

Is this still relevant @jerodsanto?

@jerodsanto
Copy link
Member

It's still a bug that hasn't been fixed, if that's what you mean by relevant?

@jerodsanto
Copy link
Member

This one is no longer relevant because we aren't proxying newsletter links anymore. Direct links FTW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants