New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant two lines of code to set io.DisplaySize in ImGuiLayer.cpp #658

Closed

littlecaca opened this issue Jan 15, 2024 · 0 comments

littlecaca commented Jan 15, 2024 •

edited

Loading

Hazel/Hazel/src/Hazel/ImGui/ImGuiLayer.cpp

Lines 100 to 101 in 1feb705

    
           Application& app = Application::Get(); 
        
           io.DisplaySize = ImVec2((float)app.GetWindow().GetWidth(), (float)app.GetWindow().GetHeight());

This is redundant because the "ImGui_ImplGlfw_NewFrame();" has done this work.
https://github.com/TheCherno/imgui/blob/3cf61f67de73153e29e0c26f23d80edbaf120a3d/examples/imgui_impl_glfw.cpp#L473-L477

littlecaca closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment