Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support No Internet Connection State #12

Closed
Spikeysanju opened this issue Oct 1, 2020 · 4 comments · Fixed by #17
Closed

Support No Internet Connection State #12

Spikeysanju opened this issue Oct 1, 2020 · 4 comments · Fixed by #17

Comments

@Spikeysanju
Copy link
Member

Spikeysanju commented Oct 1, 2020

Proposed Change

  • Support for No Internet Connection & Connection Back with animation using StateFlow
  • This change is to encourage the participants of Hacktoberfest for the this events

Expected Behaviour

⚠️ Note - Fade in & fade out collapse needs to be done!

NO INTERNET CONENCTION
NO INTERNET CONENCTION-1

Reference

StateFlow - https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/-state-flow/

@ch8n
Copy link
Member

ch8n commented Oct 3, 2020

Hi @Spikeysanju I will like to work on this

@Spikeysanju
Copy link
Member Author

Hello @ch8n , Thanks for your interest. I have updated the issue with expected behaviour of Internet connection state. Kindly take a look at it & let me know.

@ch8n
Copy link
Member

ch8n commented Oct 3, 2020

Hello @ch8n , Thanks for your interest. I have updated the issue with expected behaviour of Internet connection state. Kindly take a look at it & let me know.

Hi @Spikeysanju thanks for the quick response, please assign it to me I will get started,

just to be on the same page for requirements and intended behaviour please answer the following:

  1. No internet strip view, comes when the app goes offline?
  2. When the user is offline, will the red strip stay visible until the user is online or will be gone after some time?
  3. When the app comes online it turns green?
  4. after how much time delay would it be gone after the user is online?
  5. fade in / fade out animation will be used for switching between red and green mode?
  6. collapse animation will play on appearing and disappearing of the view?

@Spikeysanju
Copy link
Member Author

Spikeysanju commented Oct 3, 2020

@ch8n Answer for you questions

  1. Yes, if no internet the view will be displayed
  2. Yes, It will stay until user comes to online
  3. Yes, when user comes online back, "No internet connection view " will turn into "you're online" with fade in/out animation
  4. We can make time delay for 3 seconds
  5. Yes, we have to add fade in/out animation for color switch "red -> green" or "green -> red"
  6. Yes, We have to animate the view for appearing & disappearing

You can take some references from Foodium app, Try turning on & off Internet connection, you will get some idea about it

Feel free to contact me if you have any queries, Thanks you!

@Spikeysanju Spikeysanju linked a pull request Oct 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants