Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] introduce dependency injection #18

Closed
ch8n opened this issue Oct 4, 2020 · 3 comments · Fixed by #87
Closed

[Suggestion] introduce dependency injection #18

ch8n opened this issue Oct 4, 2020 · 3 comments · Fixed by #87
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@ch8n
Copy link
Member

ch8n commented Oct 4, 2020

Hi @Spikeysanju you can introduce DI in this project
if you don't want to deal with Dagger, you can do manual DI using only Kotlin,
you can see my approach from below post
https://proandroiddev.com/hold-on-before-you-dagger-or-hilt-try-this-simple-di-f674c83ebeec

@nsalazar0429
Copy link

I would use Koin. Much better

@Spikeysanju Spikeysanju added the enhancement New feature or request label Nov 9, 2020
@Spikeysanju Spikeysanju self-assigned this Nov 9, 2020
@Spikeysanju
Copy link
Member

@ch8n @cfsnsalazar Thanks for the suggestion. I'm planning to add Hilt to this project. Thanks for the contribution 🙌

@ch8n
Copy link
Member Author

ch8n commented Nov 10, 2020

@Spikeysanju how about doing it on a live stream? 🤩 👨🏻‍💻

@Spikeysanju Spikeysanju added this to To do in NYTimes-App via automation Dec 7, 2020
@Spikeysanju Spikeysanju assigned ch8n and unassigned Spikeysanju Dec 25, 2020
@Spikeysanju Spikeysanju added this to the v1.0.0-alpha01 milestone Dec 25, 2020
@ch8n ch8n linked a pull request Dec 25, 2020 that will close this issue
NYTimes-App automation moved this from To do to Done Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants