Broker ignores broker_path_style setting when accessing management bucket

[martinrohrbach]

This looks like a followup to #199.

We were very happy about this change and recently tried the latest update in our environment. In the service broker settings, we have unchecked "S3 Path style access" and when we create a bucket with the CF marketplace and create a corresponding service key then everything works as expected and the service key uses domain style (or vhost style) to access the bucket.

However, we discovered that the service broker keeps accessing its managemet bucket using path style despite the config option mentioned above.

My colleagues had a quick look through the code and might have found the problem here because the broker does not actually use the path style setting:

ecs-cf-service-broker/src/main/java/com/emc/ecs/servicebroker/config/Application.java

Lines 205 to 209 in 7bb2e23

	S3Config s3Config = new S3Config(new URI(repositoryEndpoint))
	.withUseV2Signer(!config.isAwsSignatureV4())
	.withIdentity(userName)
	.withSecretKey(repositorySecret);

Does this need the same fix as #199?

[rogalv]

Yes, host-style was not a supported for repository connection, it was implemented only for service bindings. Marking as an enhancement, planning to add to future release.