Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-97 Handle non-existent items when deleting #134

Conversation

maddisondavid
Copy link
Collaborator

When ECSService is asked to delete artifacts it currently fails if that artifact (namespace, user, bucket) has already been deleted. This PR tests to see if the requested artifact still exists before initiating the delete request to ECS.

@maddisondavid maddisondavid marked this pull request as ready for review June 23, 2020 08:58
@rogalv rogalv merged commit 77487d4 into thecodeteam:master Jul 26, 2020
@rogalv rogalv added this to To do in 2.0.1 via automation Aug 11, 2020
@rogalv rogalv linked an issue Aug 11, 2020 that may be closed by this pull request
@rogalv
Copy link
Collaborator

rogalv commented Aug 11, 2020

Appears to be a fix for issue #97, not #91

@rogalv rogalv changed the title Issue-91 Handle non-existent items when deleting Issue-97 Handle non-existent items when deleting Aug 11, 2020
@rogalv rogalv moved this from To do to Done in 2.0.1 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.0.1
  
Done
Development

Successfully merging this pull request may close these issues.

Handle failure cases for deletes/unbindings better
2 participants