Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for symfony 3.4 #119

Closed
boudewijn-zicht opened this issue Aug 7, 2019 · 3 comments
Closed

Support for symfony 3.4 #119

boudewijn-zicht opened this issue Aug 7, 2019 · 3 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@boudewijn-zicht
Copy link

We would like to use graphqlite but unfortunately we are still stuck on symfony 3.4. Are there plans to make graphqlite backwards compatible with symfony 3.4?

@moufmouf
Copy link
Member

moufmouf commented Aug 8, 2019

Hey @boudewijn-zicht ,

We have no plan to work on a Symfony 3.4 bundle so far. That being said, I don't think it would be too difficult to add support in Symfony 3.4 since I don't believe we are using features specific to Symfony 4.1+ (except in the tests)

If you are willing to have a look and work on a PR, I can happily merge it. https://github.com/thecodingmachine/graphqlite-bundle

@boudewijn-zicht
Copy link
Author

The conflict seems to be in the graphqlite library itself

1cf62b8

The above commit introduced a requirement on "symfony/cache": "^4.3", the cache contracts that are now used do not appear to exist in symfony 3.

My assumption is that this makes it quite hard to make it compatible with symfony 3... but perhaps I am wrong?

@moufmouf moufmouf added question Further information is requested wontfix This will not be worked on labels Aug 9, 2019
@moufmouf
Copy link
Member

moufmouf commented Aug 9, 2019

Ho.... you are absolutely right. Sorry, I forgot this dependency. We are using the new Symfony cache contracts, and they are indeed absolutely needed.
Reimplementing those in our code in order to be able to downgrade to Symfony cache ^3||^4 would indeed need a considerable amount of work.

Sorry about that.

@moufmouf moufmouf closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants