Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webonyx v15 #540

Closed
l-you opened this issue Jan 9, 2023 · 6 comments
Closed

Webonyx v15 #540

l-you opened this issue Jan 9, 2023 · 6 comments

Comments

@l-you
Copy link
Contributor

l-you commented Jan 9, 2023

webonyx v15.0 is out.
https://github.com/webonyx/graphql-php/releases/tag/v15.0.0

Will be both v14 and v15 supported by graphqlite? At first glance there is backward-incompatible changes

Bumping a new major version of webonyx requires updating ecodev/graphql-upload first.

@oojacoboo
Copy link
Collaborator

oojacoboo commented Jan 9, 2023

ecodev/graphql-upload doesn't support webonyx v15 yet. So, we would need to wait for support there first.

Outside of that, their update notes don't make it very clear what's likely to be broken... I guess anything "changed". But there is a lot of smaller things there that aren't likely to be a BC break.

We could start with a PR that updates the dep; see what's breaking and go from there.

@PowerKiKi
Copy link

ecodev/graphql-upload has been released with webonyx/graphql-php 15 support: https://github.com/Ecodev/graphql-upload/releases/tag/7.0.0

@oojacoboo
Copy link
Collaborator

@PowerKiKi thanks for that!
@bladl want to give a PR a shot, updating the deps - see what we're looking at?

@l-you l-you mentioned this issue Jan 12, 2023
@oojacoboo
Copy link
Collaborator

@PowerKiKi was there a specific reason for PHP 8.1 minimum support and not 8.0?

@PowerKiKi
Copy link

PowerKiKi commented Jan 15, 2023

All my projects are on PHP 8.1, and I am not too keen on the extra mental burden to support multiple PHP versions. I don't even have PHP 8.0 installed anymore. And 8.0 will be EOL quite soon in 10 months, so I don't think it's doing anyone any favor to start using something that will soon be deprecated.

According to https://packagist.org/php-statistics, PHP 8.0 is "only" ~25% of all PHP 8+, and I expect it would decrease even further with the adoption of the recent 8.2 in the coming months.

@oojacoboo
Copy link
Collaborator

@bladl @PowerKiKi thanks guys! It's been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants