Support wider array @param syntax

[juliangut]

PHPStan supports @param array syntax such as

interface MyClass
{
    /**
     * @param array<string, int> $attributes
     */
    public function __construct(array $attributes = []);
}

But \TheCodingMachine\PHPStan\Rules\TypeHints\AbstractMissingTypeHintRule returns error when analyzing the docblock

In method "\MyClass::__construct", for parameter $attributes, invalid docblock @param encountered. "\MyClass\array<string," is not a valid Fqsen.

We end up having to document as @param int[] or @param mixed[]

[moufmouf]

Interesting, I was under the impression that the "array<string, int>" was not supported by PHPStan. I'll give it another look!

AbstractMissingTypeHintRule is using "better-reflection" under the hood, that itself uses "phpdocumentor/type-resolver". I'll keep this issue open until I have some time to see if I can use the same API that PHPStan uses internally.

[juliangut]

I have not given this a thorough inspection but PHPStan holds reflection information directly on Scope (https://github.com/phpstan/phpstan/blob/master/src/Rules/FunctionDefinitionCheck.php#L79) so there should be no need to use Better Reflection but to use PHPStan's reflection

This could also fix the problem with speed phpstan-strict-rules have, if I remove them from phpstan.neon execution is much faster

[moufmouf]

Excellent idea!

That was a hell of a refactoring, but I'm almost done: #27