Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplexml won't work #46

Closed
standa opened this issue Sep 22, 2018 · 3 comments
Closed

simplexml won't work #46

standa opened this issue Sep 22, 2018 · 3 comments

Comments

@standa
Copy link

standa commented Sep 22, 2018

Unless I get the idea wrong, simplexml return types will not work.

namespace Safe;
// must return \SimpleXMLElement instead of Safe\SimpleXMLElement (class does not exist)
function simplexml_load_string(...): \SimpleXMLElement { ... }
function simplexml_load_file(...): \SimpleXMLElement { ... }
function simplexml_import_dom(...): \SimpleXMLElement { ... }

I believe this is a general problem of https://github.com/thecodingmachine/safe/blob/master/generator/src/WritePhpFunction.php#L51

@moufmouf
Copy link
Member

Jesus!!! Let's fix this immediately!

@moufmouf
Copy link
Member

Thanks a lot for the feedback. Fixed in #47.

@standa
Copy link
Author

standa commented Sep 25, 2018

@moufmouf wow respect for resolving this so quickly! One more proof for us to continue using this great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants