Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of database connects #29

Closed
TheComamba opened this issue Jun 11, 2023 · 2 comments
Closed

Reduce number of database connects #29

TheComamba opened this issue Jun 11, 2023 · 2 comments
Assignees
@Luichang
Labels
blocked Something else needs to happen before this issue can be resolved. good first issue Good for newcomers lib
Milestone
v0.1.0

Comments

@TheComamba
Copy link
Owner

The functions writing to database currently do so entry by entry, and reconnect every time.
I suggest making them expect a vector of EntityColumn etc.
@TheComamba TheComamba added good first issue Good for newcomers lib labels Jun 11, 2023
@TheComamba TheComamba added this to the v0.1.0 milestone Jun 11, 2023
@TheComamba TheComamba added the blocked Something else needs to happen before this issue can be resolved. label Jun 11, 2023
@TheComamba
Copy link
Owner Author

Should probably only be tackled once branch api-function-to-read-database is merged.

@Luichang
Copy link
Collaborator

8021574 took care of the database connections now taking a vec and thus can add multiple of the same table to the database using a single connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luichang Luichang

Labels
blocked Something else needs to happen before this issue can be resolved. good first issue Good for newcomers lib
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@Luichang @TheComamba